Fix addable in types endpoint.

robgietema · Aug 29, 2023 · b141b94 · b141b94
1 parent 962ead1
commit b141b94
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,7 @@
 - Read position in parent in update content call @robgietema
 - Apply behaviors to children in get content call @robgietema
 - Reindex parent after delete @robgietema
+- Fix addable in types endpoint @robgietema
 
 ### Internal
 

diff --git a/src/collections/type/type.js b/src/collections/type/type.js
@@ -3,9 +3,9 @@
  * @module collections/type/type
  */
 
-import { includes } from 'lodash';
+import { has, includes } from 'lodash';
 
-import { getRootUrl } from '../../helpers';
+import { getRootUrl, hasPermission } from '../../helpers';
 import { Collection } from '../../collections';
 import _ from 'lodash';
 
@@ -25,9 +25,11 @@ export class TypeCollection extends Collection {
     return _(super.toJSON())
       .map((model) => ({
         '@id': `${getRootUrl(req)}/@types/${model.id}`,
-        addable: req.type.filter_content_types
-          ? includes(req.type.allowed_content_types, model.id)
-          : model.global_allow,
+        addable:
+          hasPermission(req.permissions, 'Add') &&
+          (req.type.filter_content_types
+            ? includes(req.type.allowed_content_types, model.id)
+            : model.global_allow),
         title: req.i18n(model.title),
       }))
       .value();