Fix deprecated warning annotation conditional (#16)

* fix deprecated warning annotation conditional * ncc * bump pkg json
robherley · Apr 7, 2024 · 4dc302c · 4dc302c
1 parent 929eebe
commit 4dc302c
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/__tests__/inputs.test.ts b/__tests__/inputs.test.ts
@@ -80,4 +80,21 @@ describe('renderer', () => {
     )
     expect(core.warning).toHaveBeenCalled()
   })
+
+  it('does not make an annotation if the deprecated inputs are not used', () => {
+    mockGetInput.mockImplementation((name: string) => {
+      switch (name) {
+        case 'omitUntestedPackages':
+        case 'omitSuccessfulPackages':
+        case 'omitPie':
+          return 'false'
+        default:
+          return ''
+      }
+    })
+    mockGetBooleanInput.mockReturnValue(false)
+
+    getInputs()
+    expect(core.warning).not.toHaveBeenCalled()
+  })
 })
diff --git a/dist/index.js b/dist/index.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "go-test-action",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "GitHub Action to run go tests with rich summary output and annotations.",
   "main": "dist/index.js",
   "scripts": {

diff --git a/src/inputs.ts b/src/inputs.ts
@@ -78,24 +78,24 @@ function getDeprecatedOmitInputs(): OmitOption[] {
 
   const omitUntestedPackages = core.getInput('omitUntestedPackages')
   if (omitUntestedPackages) {
-    usedDeprecated.push('omitUntestedPackages')
     if (core.getBooleanInput('omitUntestedPackages')) {
+      usedDeprecated.push('omitUntestedPackages')
       omitOptions.push(OmitOption.Untested)
     }
   }
 
   const omitSuccessfulPackages = core.getInput('omitSuccessfulPackages')
   if (omitSuccessfulPackages) {
-    usedDeprecated.push('omitSuccessfulPackages')
     if (core.getBooleanInput('omitSuccessfulPackages')) {
+      usedDeprecated.push('omitSuccessfulPackages')
       omitOptions.push(OmitOption.Successful)
     }
   }
 
   const omitPie = core.getInput('omitPie')
   if (omitPie) {
-    usedDeprecated.push('omitPie')
     if (core.getBooleanInput('omitPie')) {
+      usedDeprecated.push('omitPie')
       omitOptions.push(OmitOption.Pie)
     }
   }