Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts POSIX compliant #45

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

saccarosium
Copy link
Contributor

There is no reason to prefer /bin/bash when none of its unique features are used. Using /bin/sh lets you run the script even on those system without bash installed (e.g. Alpine Linux, BSD etc)

Also note that using the keyword function for function declaration is not standard and you should prefer declare functions by name().

Copy link
Owner

@robherley robherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for POSIX-ing!

@robherley robherley merged commit dab0178 into robherley:main May 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants