gbm_gralloc: Add mesa libgbm to shared lib based on platform sdk version #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- From Android 11, the mesa libgbm module renamed to libgbm_mesa to avoid conflict with minigbm. So Handle it correctly based on Platform SDK version. [0] - https://android.googlesource.com/platform/external/mesa3d/+/7036b3872f7853dc732fb557dcd9b4ca31887fd6%5E%21 Signed-off-by: Dhina17 <dhinalogu@gmail.com> Change-Id: I1d86f508a7729c8279d79a18666fb080be34745b
|
Thanks, but IIRC Android-11 still uses libgbm, only 12+ use libgbm_mesa |
|
Its updated in android-11.0.0_r38 tag. https://android.googlesource.com/platform/external/mesa3d/+/refs/tags/android-11.0.0_r38/src/gbm/Android.mk#39 |
I see. Thanks for pointing out. |
|
I assume this may be interesting to you: #26 |
|
Hello @robherring , Can this be merged? |
|
related mainline mesa3d commit: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So Handle it correctly based on Platform SDK version.
[0] - https://android.googlesource.com/platform/external/mesa3d/+/7036b3872f7853dc732fb557dcd9b4ca31887fd6%5E%21
Signed-off-by: Dhina17 dhinalogu@gmail.com
Change-Id: I1d86f508a7729c8279d79a18666fb080be34745b