Adding Guzzle verify option into the constructor #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Guzzle verify option into the constructor. In some local environment people get 'cURL error 60: SSL certificate problem'. that can be avoided with this option.
```
$guzzleVerify = config('laravel-msg91.guzzle_verify', true);
$this->guzzle = new GuzzleClient(["base_uri" => $base_uri, "verify" => $guzzleVerify]);
```
And to the config file...
```
/* Guzzle Verify, if false there'll be no ssl checking (optional) */
'guzzle_verify' => env('MSG91_GUZZLE_VERIFY', true),
```
devduttabain
commented
Sep 19, 2020
| $this->guzzle = new GuzzleClient(["base_uri" => $base_uri ]); | ||
|
|
||
| //reading verify option from config, and passing that to the guzzle options | ||
| $guzzleVerify = config('laravel-msg91.guzzle_verify', true); |
There was a problem hiding this comment.
reading verify option from config, and passing that to the guzzle options
devduttabain
commented
Sep 19, 2020
| @@ -19,4 +19,7 @@ | |||
| /* Credit limit, if true message will be limted to 1 credit (optional) */ | |||
| 'limit_credit' => env('MSG91_LIMIT_CREDIT', false), | |||
|
|
|||
| /* Guzzle Verify, if false there'll be no ssl checking (optional) */ | |||
| 'guzzle_verify' => env('MSG91_GUZZLE_VERIFY', true), | |||
There was a problem hiding this comment.
adding guzzle verify option in config file
|
Looks good. I'm trying to see if there is a better terminology, or maybe we can allow passing any guzzle config as an array? The config options keep growing, and it's bothering me a bit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Guzzle verify option into the constructor. In some local environment people get 'cURL error 60: SSL certificate problem'. that can be avoided with this option.
And to the config file...