-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError unsupported operand types for URL and str #229
Comments
@samueleishion That likely is a bug, we're in the middle of major re-factor and contributions are welcome. |
Suggested change: Replace these lines https://github.com/robinhood-unofficial/pyrh/blob/master/pyrh/robinhood.py#L188-L198 with the following: historicals = (urls.HISTORICALS.with_query([
('symbols', ",".join(stock).upper()),
('interval', interval),
('span', span),
('bounds', bounds.name.lower())
])) |
@adithyabsk just saw your reply... are you taking PRs? |
@samueleishion yep |
@adithyabsk branch off and into master? |
Yep, just fork the project and commit to master and create a PR (so you're not blocked) |
Hey @adithyabsk I've created a PR but it seems to fail when running on Python 3.7.6 with a relatively vague error... any thoughts? |
@samueleishion I commented on the PR |
Checklist
Description
pyrh fails to return a result when calling function
get_historical_quotes
Steps/Code to Reproduce
Results
Expected: historical data
Actual: Error on the following line (https://github.com/robinhood-unofficial/pyrh/blob/master/pyrh/robinhood.py#L197) that reads
Versions
The text was updated successfully, but these errors were encountered: