Benchmark comparison implementation #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like it would be better suited for a wrapper around this Robinhood library. More of a set of code that implements Robinhood.py rather than be included directly in the library. @Jamonek thoughts? |
|
@hsauers5 love the work you did. mind if I copy it and add it to https://github.com/westonplatter/simple_portfolio? |
|
Thanks Weston! Please do.
…On Tue, Aug 14, 2018, 12:30 AM Weston Platter ***@***.***> wrote:
@hsauers5 <https://github.com/hsauers5> love the work you did. mind if I
copy it and add it to https://github.com/westonplatter/simple_portfolio?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZGz6AF84P-40d_4y53w1dNtLEpzW4fqks5uQlJcgaJpZM4Vw4uu>
.
|
…he day the program is run, which the Robinhood API does not support benchmark data for.
…I. Old quote_data and quotes_data left in place, but made obselete by quote_data_external and quotes_data_external. May want to revise documentation in the future.
Added external pricing API access in response to Robinhood's changes. Note that benchmark comparison logic is broken, feel free to take a look and fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork added base functionality for if the user had bought/sold an S&P 500 ETF rather than pursued their own active management. In the future, a user should be able to specify their own benchmark and alpha, beta, and other metrics would be calculated.