Expose animator options #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Override | ||
| public Animator setDuration(@IntRange(from = 0) long duration) { |
There was a problem hiding this comment.
I think the annotations here are useful but we haven't been super consistent with annnotating public APIs. We might want to spin up an issue to track adding them to other places and tag it with good first issue.
There was a problem hiding this comment.
Great to hear, I cut a ticket in this repo to track adding more annotations, #62, Unfortunately, as far as merging, I have no power in this repo ;)
danh32
reviewed
Apr 21, 2018
|
Actually, that's a backwards incompatible change, unfortunately. I'll have to make it when we make Spark 2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
Animatorclass to allow setting durations, interpolators, delays, etc.