[levenshtein][bug] Fix bug when # of changes exceeds max length of text #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danh32
approved these changes
Apr 16, 2017
| if (i == 0) { | ||
| final List<Integer> resultList = new ArrayList<>(resultLength * 2); | ||
| int row = numRows - 1; | ||
| int col = numCols - 1; |
| final int[] result = new int[resultSize]; | ||
| for (int i = 0; i < resultSize; i++) { | ||
| result[resultSize - 1 - i] = resultList.get(i); | ||
| } | ||
| return result; |
There was a problem hiding this comment.
would it be painful to make this method's return type List<Int>? would avoid needing this conversion loop here and the quickreturn above could return Collections.emptyList()
There was a problem hiding this comment.
yeah good point i'll just return them in list
There was a problem hiding this comment.
uh hm just realized that the above can't return empty list because it needs to return the number of columns with no modifications, and this iteration also adds the updates in reverse since we do reverse trace of the matrix to get the modifications. eh i'll just leave it for now lol.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46