Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent return from being optimised away by newer (>= 5.19.7) Perls. #1

Merged

Conversation

wolfsage
Copy link
Contributor

I've introduced an optimisation in blead that broke this module.

Attached is a patch to fix it.

See https://rt.perl.org/Public/Bug/Display.html?id=120792 for more information.

Thanks.

@robinhouston robinhouston merged commit b5bc0f1 into robinhouston:master Dec 15, 2013
@robinhouston
Copy link
Owner

Thanks a lot for this! Thank you also for contacting me through GitHub rather than the hideous RT system.

I’ve applied it and released Want 0.22 to CPAN.

@cpansprout
Copy link

I think you got the name wrong in the README, though. :-)

@robinhouston
Copy link
Owner

Oh, good Lord! So I did. I am ever so sorry. Corrected in 92aff5c.

Robin

On 15 December 2013 20:59, cpansprout notifications@github.com wrote:

I think you got the name wrong in the README, though. :-)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-30620129
.

@wolfsage
Copy link
Contributor Author

Hah, no worries. Thanks for the quick turnaround!

If you want, you can set up META.json / META.yml to tell search.cpan.org / metacpan.org that the bug tracker is in github, and where to find the code. It doesn't prevent bugs being entered in RT, but makes it more likely that they'll wind up in the correct place:

   "resources" : {
      "bugtracker" : {
         "web" : "https://github.com/robinhouston/Want/issues"
      },
      "homepage" : "https://github.com/robinhouston/Want/",
      "repository" : {
         "type" : "git",
         "url" : "https://github.com/robinhouston/Want/",
         "web" : "https://github.com/robinhouston/Want/"
      },
   },

Cheers,

-- Matthew Horsfall (alh)

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Apr 25, 2015
-------------------
0.22  Sun 15 Dec 2013 17:08:35 GMT
    - Prevent return from being optimised away by newer (>= 5.19.7) Perls.
      This is a patch supplied by @wolfsage: see
      robinhouston/Want#1

0.23  Mon 24 Mar 2014 00:28:36 GMT
    - Accommodate a bleadperl change to the optree, made in
      7d3c8a6837b55fff0e6294ebf8c94a1601367c76.
      This is bug #94086 for Want, and bug #121342 for perl5.

0.24  Tue  2 Dec 2014 10:22:39 GMT
    - Accommodate another bleadperl change. Patch provided by Father Chrysostomos at
      https://rt.cpan.org/Public/Bug/Display.html?id=100626

0.25  Wed 10 Dec 2014 19:31:03 GMT
    - Add support for the new OP_MULTIDEREF
      Perl has a new op, added as a performance optimisation
      in fedf30e1c349130b23648c022f5f3cb4ad7928f3, to
      represent a sequence of array/hash dereferences. This
      patch adds support for the new op.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants