Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for registering consumer at specific Message ID #7

Merged
merged 1 commit into from
May 25, 2020

Conversation

theckman
Copy link
Contributor

@theckman theckman commented May 9, 2020

Some consumers may not want to process old messages in the stream, and to
instead only start consuming from the latest. This adds a RegisterWithID
function that allows you to specify any message ID. Per the Redis documention,
0 means the oldest message in the stream while $ means the latest.

Fixes #6

@theckman
Copy link
Contributor Author

@robinjoseph08 might you have a moment to 👀 and :shipit: into a tagged release?

Copy link
Owner

@robinjoseph08 robinjoseph08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment about documentation, but after that change, I'll merge and create a new release 👍

consumer.go Outdated Show resolved Hide resolved
Some consumers may not want to process old messages in the stream, and to
instead only start consuming from the latest. This adds a RegisterWithID
function that allows you to specify any message ID. Per the Redis documention,
`0` means the oldest message in the stream while `$` means the latest.

Fixes robinjoseph08#6
@theckman
Copy link
Contributor Author

theckman commented May 25, 2020

I raised another PR while I have your 👀. 😄

This one should be ready to go!

@robinjoseph08 robinjoseph08 merged commit 13b26dc into robinjoseph08:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating groups from end of stream, not just beginning
2 participants