Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.6.0 #607

Merged
merged 3 commits into from
Apr 8, 2024
Merged

v4.6.0 #607

merged 3 commits into from
Apr 8, 2024

Conversation

stickpin
Copy link
Collaborator

Change log:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Code quality improvements to existing code or addition of tests

@stickpin stickpin added the enhancement New feature or request label Mar 17, 2024
@stickpin
Copy link
Collaborator Author

Hi @robinostlund,
Please merge this one.

@stickpin
Copy link
Collaborator Author

Hi @robinostlund,

Please allow me to merge the PR myself without additional reviews, unfortunately, there are no other active developers anymore, and PRs are getting stuck for no reason. If you don't want to, it's also fine, please let me know and I will start running a separate repo, the same way as skodaconnect is running for example, with the future evolution of Volkswagen Connect. I prefer not to do it but it's your call.

Thanks. :)

@stickpin
Copy link
Collaborator Author

stickpin commented Apr 8, 2024

3 weeks passed and no response.
I guess @robinostlund is focused on something more important.
I will start running a separate repo to remove the dependency and unblock the evolution of VW Connect (even though, I don't like this idea).

@stickpin stickpin closed this Apr 8, 2024
@robinostlund
Copy link
Owner

@stickpin sorry i totally missed your message, i have been starting a new job so it has been alot of other things to take care of :) i can try to change the settings of this repo so you should be able to merge by yourself.

@robinostlund
Copy link
Owner

I removed so it doesn't require a review now so i think that should be enough, please try @stickpin

@stickpin stickpin reopened this Apr 8, 2024
@stickpin
Copy link
Collaborator Author

stickpin commented Apr 8, 2024

@robinostlund we need to find a better way to communicate... :) If it's ok, drop me your phone number to stickpins at gmail dot com and we will connect via some messenger (Signal, Threema, Telegramm or WhatsApp)

And yes, I can merge now with a review. :)

@stickpin stickpin merged commit 6f6c959 into master Apr 8, 2024
11 checks passed
@stickpin stickpin deleted the v4.6.0 branch April 8, 2024 15:01
@stickpin stickpin restored the v4.6.0 branch April 8, 2024 15:01
@stickpin stickpin deleted the v4.6.0 branch April 8, 2024 15:09
@virtualdj
Copy link

even though, I don't like this idea

Yeah, having this original repo to survive (and be updated) is also great to keep the history of bugs/feature requests that would disappear in a fork.

Thanks to both of you!

i have been starting a new job

Congratulations for your new job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants