Fix version command when built from source

robinovitch61 · Jul 22, 2022 · 7f7e00f · 7f7e00f
1 parent 611e9bd
commit 7f7e00f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/cmd/util.go b/cmd/util.go
@@ -8,6 +8,7 @@ import (
 	"github.com/gliderlabs/ssh"
 	"github.com/hashicorp/nomad/api"
 	"github.com/robinovitch61/wander/internal/tui/components/app"
+	"github.com/robinovitch61/wander/internal/tui/constants"
 	"github.com/robinovitch61/wander/internal/tui/nomad"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
@@ -289,5 +290,8 @@ func setup(cmd *cobra.Command, overrideToken string) (app.Model, []tea.ProgramOp
 }
 
 func getVersion() string {
+	if Version == "" {
+		return constants.NoVersionString
+	}
 	return Version
 }
diff --git a/internal/tui/components/app/app.go b/internal/tui/components/app/app.go
@@ -547,7 +547,7 @@ func (m Model) getFilterPrefix(page nomad.Page) string {
 
 func getVersionString(v, s string) string {
 	if v == "" {
-		return "built from source"
+		return constants.NoVersionString
 	}
 	return fmt.Sprintf("%s (%s)", v, s[:7])
 }
diff --git a/internal/tui/constants/constants.go b/internal/tui/constants/constants.go
@@ -7,6 +7,8 @@ import (
 	"time"
 )
 
+const NoVersionString = "built from source"
+
 var LogoString = strings.Join([]string{
 	"█ █ █ █▀█ █▄ █ █▀▄ █▀▀ █▀█",
 	"▀▄▀▄▀ █▀█ █ ▀█ █▄▀ ██▄ █▀▄",