Trigger overflow content check on setContent()

[MicahBrown]

I'm appending ajax-ed content to the modal using setContent(). The issue is that the content is initially blank when the modal is opened and doesn't overflow the page. However, when the content is added, it overflows the page and the .tingle-modal--overflow class is never added since it only triggers on window resize (as I can see), but not setContent(). I therefore cannot scroll with the content now overflowing the page.

My work around looks something like this:

var modal = new tingle.modal();
modal.open(); // modal content doesn't yet overflow the page at this point since it's blank

$.get('/ajax_content_url', function(response){
  modal.setContent(response) // modal content now overflows page, but I can't scroll since there's no .tingle-modal--overflow in the modal classes
  modal._events.resize() // here's my workaround; manually calling resize to check if new content makes modal overflow page
})

But I think setContent() should trigger the resize event automatically.

[robinparisi]

Hi @MicahBrown,

There is a public method specially made for this case:

var modal = new tingle.modal();
modal.open(); // modal content doesn't yet overflow the page at this point since it's blank

$.get('/ajax_content_url', function(response){
  modal.setContent(response);
  modal.checkOverflow();
})

In most cases, users set content first then open the modal. The checkOverflow() method needs an opened modal to work properly so I made this check in open() method. In other cases, you need to call checkOverflow() yourself.

[MicahBrown]

That may be so. I still think that checkOverflow should be called within setContent since it's an entry point for new dynamic content. Don't you think?

…

On Tue, Mar 27, 2018, 6:06 AM Robin Parisi ***@***.***> wrote: Hi @MicahBrown <https://github.com/MicahBrown>, There is a public method specially made for this case: var modal = new tingle.modal();modal.open(); // modal content doesn't yet overflow the page at this point since it's blank $.get('/ajax_content_url', function(response){ modal.setContent(response); modal.checkOverflow(); }) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEDXRopHCoVWjfy4Mo5JfhlixLfLCneyks5tih0YgaJpZM4S79fy> .

[robinparisi]

In this case, it would be great to check if the modal is open before calling the checkOverflow method in setContent.

[MicahBrown]

@robinparisi I updated my PR.

[robinparisi]

@MicahBrown Thanks, I've just merged your PR. It will be available in the next release.

[MicahBrown]

Sweet, thanks!

…

On Tue, Mar 27, 2018, 12:15 PM Robin Parisi ***@***.***> wrote: @MicahBrown <https://github.com/MicahBrown> Thanks, I've just merged your PR. It will be available in the next release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEDXRsuVUNrGsNm-_5FzaLwgriNzSj2-ks5tinO3gaJpZM4S79fy> .