Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error code if connection is dropped #7

Closed
JekRock opened this issue Nov 13, 2018 · 0 comments
Closed

No error code if connection is dropped #7

JekRock opened this issue Nov 13, 2018 · 0 comments

Comments

@JekRock
Copy link
Contributor

JekRock commented Nov 13, 2018

I had the following bug. I sent two AGWriteDB requests and between these two requests the connection to plc was dropped (I've emulated this by disconnecting the network on PC). After the second request I didn't get any error but there was no data in DB. And after all following request the same.
I've found that the bug was in this line. Here the error message from this line should be returned, but it's kinda hidden by err variable from the writeArea function (I'm not an expert in Go, so I don't know how it has happened. I'll be gratefull if you explain this).
I've changed error variable name and it has solved the bug.
Please check the pull request #6

@JekRock JekRock closed this as completed Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant