-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the HEAD command #33
Changes from 5 commits
bf1f3cb
05b5a5b
0d8fb34
60b2205
970bd2b
842a4de
369465c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the NNTP library. | ||
* | ||
* (c) Robin van der Vleuten <robin@webstronauts.co> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Rvdv\Nntp\Command; | ||
|
||
use Rvdv\Nntp\Exception\RuntimeException; | ||
use Rvdv\Nntp\Response\MultiLineResponse; | ||
use Rvdv\Nntp\Response\Response; | ||
|
||
/** | ||
* HeadCommand. | ||
* | ||
* @author elabz | ||
*/ | ||
class HeadCommand extends Command implements CommandInterface | ||
{ | ||
/** | ||
* @var string | ||
*/ | ||
private $article; | ||
|
||
/** | ||
* Constructor. | ||
* | ||
* @param string $article | ||
*/ | ||
public function __construct($article) | ||
{ | ||
$this->article = $article; | ||
|
||
parent::__construct(true); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function __invoke() | ||
{ | ||
return sprintf('HEAD %s', $this->article); | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function onHeadFollows(MultiLineResponse $response) | ||
{ | ||
$headers = []; | ||
array_map(function ($line) use (&$headers) { | ||
preg_match('/^([^\:]+)\:\s*(.*)$/', $line, $matches); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, we do seem to have a genuine problem with multi-line fields within multi-line responses. news.php.net may be quite a bit busier than most, but they seem to have spliced super-long lines with \n\t ins some cases and \n\s in others. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may be safer to return the head as a string like the pear nntp class does and leave the name/value pair parsing to a wrapper class as not all users will need the data converted like this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair enough @thebandit , I will refactor. Will leave the parsing of the full header to the application. It will essentially become a twin of the body command There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well see what @robinvdvleuten has to say as it's his project (I'm just an end-user like yourself). I was just offering a suggestion as it looks like this project tries to mimic the output of the pear class when possible. |
||
if (!empty($matches)) { | ||
$headers[$matches[1]] = trim($matches[2]); | ||
} | ||
}, $response->getLines()); | ||
|
||
return $headers; | ||
} | ||
|
||
public function onNoNewsGroupCurrentSelected(Response $response) | ||
{ | ||
throw new RuntimeException('A group must be selected first before getting an article header.', $response->getStatusCode()); | ||
} | ||
|
||
public function onNoSuchArticleNumber(Response $response) | ||
{ | ||
throw new RuntimeException('No article with that number.', $response->getStatusCode()); | ||
} | ||
|
||
public function onNoSuchArticleId(Response $response) | ||
{ | ||
throw new RuntimeException('No article with that message-id.', $response->getStatusCode()); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make an array_reduce of this?