This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Made paths accept null #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ export default function(options, storage, key) { | |||
| } | |||
|
|
|||
| function reducer(state, paths) { | |||
| return paths.length === 0 | |||
| return paths === null || paths === undefined | |||
There was a problem hiding this comment.
What about !Array.isArray(path) instead of checking both null and undefined?
|
Maybe it is a good idea to add a note to the |
|
Sorry for letting this dangle. Totally fell between my fingers. Glad you implemented it, thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Made
pathsacceptnullas value instead of an empty array.Why: See #238
How: Removed
options.pathsdefault to[]. Also added a check forpaths == nullChecklist: