Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FelaDOM casing #811

Merged
merged 1 commit into from Oct 1, 2020
Merged

Fix FelaDOM casing #811

merged 1 commit into from Oct 1, 2020

Conversation

jp7837
Copy link
Contributor

@jp7837 jp7837 commented Sep 17, 2020

Description

Fix FelaDOM casing to be consistent with previous versions that had UMD bundles

Example

N/A

Packages

  • fela-dom

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • [ x ] The code was formatted using Prettier (yarn run format)
  • [ x ] The code has no linting errors (yarn run lint)
  • [ x ] All tests are passing (yarn run test)
  • [ x ] There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • [ x ] Tests have been added/updated
  • [ x ] Documentation has been added/updated
  • [ x ] My changes have proper flow-types

To be consistent with previous versions that had UMD bundles
@robinweser robinweser merged commit 2b9af08 into robinweser:master Oct 1, 2020
@robinweser
Copy link
Owner

Thanks for the PR, haven't noticed we changed alignment here.

@jp7837
Copy link
Contributor Author

jp7837 commented Oct 1, 2020

Thanks for the PR, haven't noticed we changed alignment here.

Took me 3 PR's to get it right 😅 (#773, #805)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants