Accuracy for tbats/bats objects #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed bug in bizdays() #124
* 'master' of https://github.com/robjhyndman/forecast: fixed bug in bizdays() #124
added more useful badges on README
fixed issue112 bug. Checks whether the data is univariate time series
fixed broken coverage status
When running a VAR with exogenous variables, one needs to provide the `dumvar`argument to `predict.varest`. Therefore, I just added the `...` to the `predict` function it can pass `dumvar`.
Update forecast.varest.R
This reverts commit 302749d.
Added more tests to boost coverage
|
Only that I haven't tested it. It should work ok though. Feel free to test it out and submit a pull request. |
robjhyndman
added a commit
that referenced
this pull request
Aug 16, 2015
Accuracy for tbats/bats objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason why the accuracy function does not support tbats/bats objects? I see in the
accuracy()function there is code to check the class:if (!any(is.element(class(f), c("mforecast", "forecast", "ts", "integer", "numeric", "Arima", "ets", "lm"))))Obviously I could check the accuracy of a tbats manually by taking the
fitted()values withmytbats <- tbats(taylor); accuracy(fitted(mytbats), taylor)Is there a theoretical reason why the fitted values of a tbats are not appropriate for computing in-sample accuracy or why it isn't allowed in the
accuracy()function? Thetbats()documentation describes accessing the tbats'fitted.valueswhich leads me to believe it isn't a statistical issue with using the fitted values.