..

roblesterjr04 · Jan 10, 2024 · ce7a879 · ce7a879
1 parent b46e94d
commit ce7a879
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Checks/Checks/GitHubActionsCheck.php b/src/Checks/Checks/GitHubActionsCheck.php
@@ -32,6 +32,8 @@ public function run(): Result
 				} 
 
 				if ($run['conclusion'] == 'failure') return $result->failed();
+
+				return $result->ok();
 			}
 		}
 

diff --git a/tests/GitHubTest.php b/tests/GitHubTest.php
@@ -30,7 +30,7 @@ public function testTerminalCheck()
 		$this->assertInstanceOf('Lester\Health\Checks\Result', $result);
 	}
 
-	public function testPingRedirectCheck()
+	public function testGithubActions()
 	{
 
 		Http::fake([
@@ -41,6 +41,7 @@ public function testPingRedirectCheck()
 					],
 					[
 						'name' => 'Test Flow',
+						'status' => 'completed',
 						'conclusion' => 'failure'
 					]
 				]