Add support for variable file extensions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow single element wildcards in the last path segment to end with an extension
roblillack
force-pushed
the
17-add-support-for-variable-file-extensions
branch
from
e4689e1
to
05ef321
Compare
roblillack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
internal/pathtreeHow to use this feature
Given a route definition like these:
GET /dir/:filename.:ext MyController.ExportFile(Basename of file is variable, too)GET /dir/filename.:ext MyController.ExportExt(Basename of file is static, only extension is variable)GET /dir/:filename.png MyController.ExportPNG(Basename of file is variable, extension is not; this was available before)you're now able to use Actions like these:
(c *MyController) ExportFile(filename, ext string) mars.Result(variable basename)(c *MyController) ExportExt(ext string) mars.Result(static basename)(c *MyController) ExportPNG(filename string) mars.Result(static extension)Routes with fixed path with variable extension will always get higher priority than variable filename with fixed extension. So, a request to
/dir/filename.pngwould be handled byExportExt("png")instead ofExportPNG("filename")for the example above.Ticket: #17