Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move watcher to internal package, clean up, add tests #22

Merged
merged 8 commits into from
Mar 23, 2021

Conversation

roblillack
Copy link
Owner

@roblillack roblillack commented Mar 23, 2021

This change set:

  • Moves the Watcher type to an internal package ./internal/watcher
  • Adds two unit tests to said functionality
  • Cleans up error handling of the watcher (return more errors more often)
  • Drops anything from the watching code that was necessary to do compilation (eager watching, forced refresh)
  • Removes functionality to have listener filter based on file/dir name (DiscerningListener)
  • Removes unnecessary utility functions

The code uses wrapped errors, so minimum Go version will be 1.13 as soon as this is merged.

Ticket: #16

@roblillack roblillack force-pushed the 16-hide-some-internal-data-structures branch from a575d1b to 5a30833 Compare March 23, 2021 10:53
@coveralls
Copy link

coveralls commented Mar 23, 2021

Coverage Status

Coverage decreased (-0.6%) to 59.897% when pulling b717104 on 16-hide-some-internal-data-structures into 60bd1e5 on master.

@roblillack roblillack merged commit 90e0d08 into master Mar 23, 2021
@roblillack roblillack deleted the 16-hide-some-internal-data-structures branch March 23, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants