Skip to content

Commit

Permalink
Remove usage of luau.MixedTable
Browse files Browse the repository at this point in the history
  • Loading branch information
osyrisrblx committed Feb 14, 2024
1 parent 6df20d2 commit e83336d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 51 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function createBoilerplate(
luau.create(luau.SyntaxKind.Assignment, {
left: className,
operator: "=",
right: luau.mixedTable(),
right: luau.map(),
}),
);
} else {
Expand Down
8 changes: 0 additions & 8 deletions src/TSTransformer/util/expressionMightMutate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@ export function expressionMightMutate(
expression.fields,
field => expressionMightMutate(state, field.index) || expressionMightMutate(state, field.value),
);
} else if (luau.isMixedTable(expression)) {
return luau.list.some(expression.fields, field => {
if (luau.isMapField(field)) {
return expressionMightMutate(state, field.index) || expressionMightMutate(state, field.value);
} else {
return expressionMightMutate(state, field);
}
});
} else {
if (node) {
node = skipDownwards(node);
Expand Down
42 changes: 0 additions & 42 deletions src/TSTransformer/util/pointer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export interface Pointer<T> {

export type MapPointer = Pointer<luau.Map | luau.TemporaryIdentifier>;
export type ArrayPointer = Pointer<luau.Array | luau.TemporaryIdentifier>;
export type MixedTablePointer = Pointer<luau.MixedTable | luau.TemporaryIdentifier>;

export function createMapPointer(name: string): MapPointer {
return { name, value: luau.map() };
Expand All @@ -18,10 +17,6 @@ export function createArrayPointer(name: string): ArrayPointer {
return { name, value: luau.array() };
}

export function createMixedTablePointer(name: string): MixedTablePointer {
return { name, value: luau.mixedTable() };
}

export function assignToMapPointer(
state: TransformState,
ptr: Pointer<luau.Map | luau.AnyIdentifier>,
Expand Down Expand Up @@ -50,34 +45,6 @@ export function assignToMapPointer(
}
}

export function assignToMixedTablePointer(
state: TransformState,
ptr: MixedTablePointer,
left: luau.Expression,
right: luau.Expression,
) {
if (luau.isMixedTable(ptr.value)) {
luau.list.push(
ptr.value.fields,
luau.create(luau.SyntaxKind.MapField, {
index: left,
value: right,
}),
);
} else {
state.prereq(
luau.create(luau.SyntaxKind.Assignment, {
left: luau.create(luau.SyntaxKind.ComputedIndexExpression, {
expression: ptr.value,
index: left,
}),
operator: "=",
right,
}),
);
}
}

export function disableMapInline(
state: TransformState,
ptr: MapPointer,
Expand All @@ -95,12 +62,3 @@ export function disableArrayInline(
ptr.value = state.pushToVar(ptr.value, ptr.name);
}
}

export function disableMixedTableInline(
state: TransformState,
ptr: MixedTablePointer,
): asserts ptr is Pointer<luau.TemporaryIdentifier> {
if (luau.isMixedTable(ptr.value)) {
ptr.value = state.pushToVar(ptr.value, ptr.name);
}
}

0 comments on commit e83336d

Please sign in to comment.