Skip to content
This repository has been archived by the owner on Jul 23, 2021. It is now read-only.

Fix 213 #214

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Fix 213 #214

merged 4 commits into from
Feb 12, 2020

Conversation

robmarkcole
Copy link
Owner

Fix #213

@coveralls
Copy link

coveralls commented Feb 12, 2020

Pull Request Test Coverage Report for Build 60

  • 8 of 9 (88.89%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 30.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/huesensor/device_tracker.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
custom_components/huesensor/device_tracker.py 2 0%
Totals Coverage Status
Change from base Build 54: 0.09%
Covered Lines: 106
Relevant Lines: 347

💛 - Coveralls

@robmarkcole robmarkcole merged commit 5132da4 into master Feb 12, 2020
@robmarkcole robmarkcole deleted the fix-213 branch February 12, 2020 07:59
@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #214 into master will increase coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   30.45%   30.54%   +0.08%     
==========================================
  Files           4        4              
  Lines         348      347       -1     
==========================================
  Hits          106      106              
+ Misses        242      241       -1
Impacted Files Coverage Δ
custom_components/huesensor/device_tracker.py 0% <0%> (ø) ⬆️
custom_components/huesensor/remote.py 31.37% <100%> (-0.45%) ⬇️
custom_components/huesensor/__init__.py 35.29% <100%> (+8.62%) ⬆️
custom_components/huesensor/binary_sensor.py 41.93% <100%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35016a8...0db38c4. Read the comment docs.

@Mariusthvdb
Copy link
Contributor

HI Rob,

just to let you know, and ask if/how this could be possible:

after this fix, deleting the dependencies from all files, my HA instance has calmed down enormously and the constant unavailability of the Hue lights has diminished a great deal...
This unavailability has been a thing pestering a lot of people a long time, and without the various iterations of HA hue integration and this CC been more prominent a times. It was 'solved' (for me) when we were at 104.3 HA.

Then updating to 105 it came back in all its frustrating intensity. This might have been coinciding with the updates and splitting up in the HUE CC repo here.

Now you've updated the init.py and streamlined the others, and as said, especially taking out

 DEPENDENCIES = ["hue"]

HA responds much better.
There's still a few errors around in the logs about fetching data, but they are supposed to be solved in 106.

Did the DEPENDENCIES = ["hue"] have such impact? It almost feels like another HA instance altogether.

Would be interested in your view on this.
Keep on streamlining the CC, it makes a world of difference!
Thanks.

@robmarkcole
Copy link
Owner Author

DEPENDENCIES = ["hue"] was actually doing nothing, as the dependencies are defined in manifest.json

@Mariusthvdb
Copy link
Contributor

hmm, that's odd. Just did a config check, which took ages since mentioned updates, and it was swift as before, after the fix you did.

either that, or the update to supervisor 200 made the difference. Nothing else changed on this side.

@robmarkcole
Copy link
Owner Author

its a mystery :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name '_LOGGER' is not defined
4 participants