Skip to content
This repository has been archived by the owner on Jul 23, 2021. It is now read-only.

Use the same data source as Home Assistant #221

Merged
merged 3 commits into from
Mar 8, 2020

Conversation

azogue
Copy link
Contributor

@azogue azogue commented Mar 8, 2020

Description

Quickfix to, at least, share the API calls with the main Hue integration, using the sensor manager coordinator form there.

Even without increasing the SCAN_INTERVAL's used here, this should reduce a bit the induced stress in the Hue bridge.

Relates to #220 and #215

cc @robmarkcole

Notes
  • It does not address anything more than the API call, for now.

instead of doing extra calls to the Hue bridge
and bump HA version for tests up to 0.106.4
@robmarkcole
Copy link
Owner

robmarkcole commented Mar 8, 2020

Many thanks! Can you take a look into the Travis error? On babysitting duty with my hands full

@azogue
Copy link
Contributor Author

azogue commented Mar 8, 2020

Many thanks! Can you take a look into the Travis error?

Yeah, no problem. It seems related to attrs version someway (result of the bumping, I suppose, but local tests pass)

On babysitting duty with my hands full

Best regards to all the family :) Hope everything is great, congrats!

And pin attrs version in requirements.txt
@coveralls
Copy link

Pull Request Test Coverage Report for Build 73

  • 7 of 13 (53.85%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 31.003%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/huesensor/binary_sensor.py 1 2 50.0%
custom_components/huesensor/remote.py 3 4 75.0%
custom_components/huesensor/device_tracker.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
custom_components/huesensor/init.py 1 75.0%
custom_components/huesensor/device_tracker.py 3 0%
Totals Coverage Status
Change from base Build 69: 0.8%
Covered Lines: 102
Relevant Lines: 329

💛 - Coveralls

@robmarkcole
Copy link
Owner

Fantastic, thanks @azogue !

@robmarkcole robmarkcole merged commit ee56542 into robmarkcole:master Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants