Allow console input to be used within adapters #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `removeIndex()` was mentioned in the docs. It took me quite a while to figure out that it expected the field names (and not the index names), so I'm adding the reference.
* 0.6.x-dev: Prepare v0.6.4 Update CHANGELING to prepare for v0.6.4 release Update README.md to point to master for badges Fix SQLite adapter drops table on changeColumn if there's a foreign key Update TextWrapper.php Update TextWrapper.php To use phinx for unit testing, sometimes is necessary to run not just the migrations, but the seeds as well. This commit add a new method getSeed that runs the seeds. When setting options as a non-associative array, Column fails with "Call to undefined method Phinx\Db\Table\Column::set0()". This check makes sure the developer gets an appropriate message. doc block updated Removed unused var Fix more missing return value and type Added missing return value Update README.md Getter should match setter. \\Phinx\\Console\\Command\\Create.php:21 uses getMigrationBaseClassName() so it is added to the interface Unused variable Class properties should be declared
Added mention to removeIndexByName()
|
@bgetsug I'm changing it to be merged with |
|
@bgetsug does this PR actually add any methods to the adapter classes? |
|
@robmorgan I did not add any new methods to existing adapter classes. It's just that the instance of |
|
@bgetsug right I see, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a custom adapter that needed to access the (symfony) console options, and I needed to make this change to make that possible.