Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reward clip is badly implemented #19

Closed
FelipeMartins96 opened this issue Feb 22, 2021 · 1 comment
Closed

Move reward clip is badly implemented #19

FelipeMartins96 opened this issue Feb 22, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@FelipeMartins96
Copy link
Member

When implemented in the old environment, the intention was to clip rewards when something unexpected occurred and the value was too big, on the code as of now it is clipping normal rewards

https://github.com/robocin/envs/blob/5f422179ca24fdf9eca0bf53fe02f2af1a4c6f21/envs/rc_gym/vss/env_3v3/vss_gym_3v3.py#L194
@FelipeMartins96 FelipeMartins96 added the bug Something isn't working label Feb 22, 2021
@FelipeMartins96
Copy link
Member Author

maybe the same thing occurs here
https://github.com/robocin/envs/blob/b4e98159dc03a604e7413bb280e46f7f69199cd9/envs/rc_gym/vss/env_3v3/vss_gym_3v3.py#L179

FelipeMartins96 added a commit that referenced this issue Mar 1, 2021
@FelipeMartins96
fixes #19
fdbaea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FelipeMartins96