Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New library OpenAI #792

Merged
merged 2 commits into from Feb 6, 2023
Merged

New library OpenAI #792

merged 2 commits into from Feb 6, 2023

Conversation

orlof
Copy link
Contributor

@orlof orlof commented Jan 31, 2023

separate package due to python incompatibility with rpafw

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@orlof orlof changed the title Feature/openai New library OpenAI Jan 31, 2023
mikahanninen
mikahanninen requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@mikahanninen mikahanninen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a overall comment, the package should have some tests. At least Robot Framework tests.

packages/openai/src/RPA/OpenAI.py Show resolved Hide resolved
packages/openai/src/RPA/OpenAI.py Outdated Show resolved Hide resolved
packages/openai/src/RPA/OpenAI.py Outdated Show resolved Hide resolved
packages/openai/src/RPA/OpenAI.py Outdated Show resolved Hide resolved
packages/openai/src/RPA/OpenAI.py Outdated Show resolved Hide resolved
@orlof orlof force-pushed the feature/openai branch 2 times, most recently from 688ccea to a3dca8f Compare February 6, 2023 06:41
@orlof orlof merged commit d0976d9 into master Feb 6, 2023
@orlof orlof deleted the feature/openai branch February 6, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikahanninen mikahanninen mikahanninen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orlof @CLAassistant @mikahanninen