Update sales results html #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihardsgravis
approved these changes
Aug 9, 2021
|
@rihardsgravis Setting you as the reviewer. The last prod deployment (I guess using Vercel?) was a very long time ago, so I do not dare to merge this without having some knowledgeable backup available in case something has changed in the deploy process and requires updates (don't want to cause downtime on the beginners' course site). If you happen to have time after you come back, could you check if merging this PR deploys correctly? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sales results HTML so that the current HTML -> PDF implementation can produce better output. The current
widthattribute value causes only one column to fit in the generated PDF. This used to work with the older versions. Updating the width value avoids this issue.Update dependencies.