Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit documentation in GameEvent #18

Closed
rolfvdhulst opened this issue Nov 2, 2020 · 4 comments
Closed

Unit documentation in GameEvent #18

rolfvdhulst opened this issue Nov 2, 2020 · 4 comments

Comments

@rolfvdhulst
Copy link

Currently there's no documentation for a large part of the fields of what units they have for GameEvent, particularly the locations. Are these in meters? or millimiters (ssl-vision standard?)?

@g3force
Copy link
Member

g3force commented Nov 3, 2020

Oh, you are right... That documentation really is missing :/ All the protobuf files should be documented.
I tried to use SI units where ever possible. So it should be meters.
Except for the referee message, where the placement position is in mm for historical reasons.

@g3force
Copy link
Member

g3force commented Nov 14, 2020

I've updated the documentation

@g3force
Copy link
Member

g3force commented Nov 20, 2020

Do you think this is sufficient, or is there something that still really needs more documentation?

@rolfvdhulst
Copy link
Author

Yes, this is more than sufficient! 👍 Thank you!

@g3force g3force closed this as completed Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants