Peter/fix orjson #192
Merged
Peter/fix orjson #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelPeczek-Roboflow
approved these changes
Dec 14, 2023
| ) | ||
|
|
||
|
|
||
| def default(obj): |
There was a problem hiding this comment.
please add typing
requirements/_requirements.txt
Outdated
| @@ -18,3 +18,4 @@ requests-toolbelt>=1.0.0 | |||
| wheel>=0.38.1 | |||
| setuptools>=65.5.1 | |||
| pytest-asyncio<=0.21.1 | |||
| orjson | |||
There was a problem hiding this comment.
maybe a better placement would be requirements.http.txt?
There was a problem hiding this comment.
Agreed! And can we pin orjson?
paulguerrie
reviewed
Dec 14, 2023
requirements/_requirements.txt
Outdated
| @@ -18,3 +18,4 @@ requests-toolbelt>=1.0.0 | |||
| wheel>=0.38.1 | |||
| setuptools>=65.5.1 | |||
| pytest-asyncio<=0.21.1 | |||
| orjson | |||
There was a problem hiding this comment.
Agreed! And can we pin orjson?
paulguerrie
approved these changes
Dec 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroduce orjson with fixes for visualizations in responses
Add visualization tests to regression testing
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Locally
Any specific deployment considerations
Non
Docs