Skip encode image as jpeg if no-resize is specified #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificDou
requested review from
PawelPeczek-Roboflow,
probicheaux and
bigbitbus
PawelPeczek-Roboflow
approved these changes
Apr 18, 2024
|
please cover with some test |
bigbitbus
approved these changes
Apr 18, 2024
probicheaux
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inference_sdk will forcibly encode image as jpeg (and then convert to base64 string) before sending request to inference server, this is not necessary and not expected.
We have the requirement from Duolingo that they want to keep the original image quality, but jpeg encoding will degrade image quality and affect the inference results.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested locally.