Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug in get_data_item for np.array index #1059

Closed

Conversation

MoHoss007
Copy link

@MoHoss007 MoHoss007 commented Mar 28, 2024

Description

fixed a bug in get_data_item for np.array index, there was a bug when trying to mask detections using np.array and the list values in data field were not getting updated properly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change.

It was tested as part of my personal project. example:

# detections was created before:
detections.data["test_data"] = [None for _ in range(len(detections))]
detections = detections[detections.confidence > 0.5]
# this would lead to error in validation function without the current changes, since the size of data["test_data"] will not change.

Any specific deployment considerations

N/A

Docs

  • N/A

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@SkalskiP
Copy link
Collaborator

Hi, @MoHoss007 👋🏻 thanks a lot for your interest in supervision and the time you spend working on this PR. It looks like we just merged alternative PR to solve this issue. You can learn more from the links below.

@SkalskiP SkalskiP closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants