Skip to content

Feature/ultralytics all models - #222

Merged
SkalskiP merged 7 commits into
roboflow:developfrom
hardikdava:feature/ultralytics_all_models
Jul 31, 2023
Merged

SkalskiP merged 7 commits into
roboflow:developfrom
hardikdava:feature/ultralytics_all_models

Conversation

@hardikdava

Copy link
Copy Markdown
Contributor

This PR is related to #221

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Docs

  • Docs updated? What were the changes:

@hardikdava

Copy link
Copy Markdown
Contributor Author

Hello @SkalskiP 馃憢 , I finished this feature. Please test it with this colab: https://colab.research.google.com/drive/1PST2Yv56IjmKvn6J0I3JCGMT-IgDTEC_?usp=sharing

I have added tests for all the models and deprecated for existing api sv.Detections.from_yolov8(). Let me know if you have any trouble with tests.

@hardikdava
hardikdava marked this pull request as ready for review July 22, 2023 18:23
@SkalskiP SkalskiP added the enhancement New feature or request label Jul 22, 2023
@SkalskiP SkalskiP added this to the version: 0.13.0 milestone Jul 22, 2023
@SkalskiP

Copy link
Copy Markdown
Collaborator

Hi, @hardikdava 馃憢馃徎! Awesome, let's have it ready for the supervision-0.13.0 release.

@SkalskiP SkalskiP added the version: 0.13.0 Feature to be added in `0.13.0` release label Jul 23, 2023
@SkalskiP
SkalskiP changed the base branch from main to develop July 23, 2023 19:10
@hardikdava

Copy link
Copy Markdown
Contributor Author

@SkalskiP this feature is ready for review. please review it and merge it.

Comment thread supervision/dataset/core.py Outdated

@hardikdava hardikdava left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it require any further modification?

@SkalskiP SkalskiP mentioned this pull request Jul 31, 2023
1 task done
@SkalskiP

Copy link
Copy Markdown
Collaborator

@hardikdava I tested your notebook. It works, and it is fantastic! Merging.

@SkalskiP
SkalskiP merged commit f2bbb7c into roboflow:develop Jul 31, 2023
@hardikdava
hardikdava deleted the feature/ultralytics_all_models branch August 10, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request version: 0.13.0 Feature to be added in `0.13.0` release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants