Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linezone.trigger returns bool nparray #482

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Linezone.trigger returns bool nparray #482

merged 3 commits into from
Oct 18, 2023

Conversation

abhishek7kalra
Copy link
Contributor

Description

As requested in the issue #464 , I have made the necessary changes. Now the sv.LineZone.trigger returns a bool nparray which indicates the object's state change (indicating it has crossed the line). The implementation is similar to that of sv.PolygonZone.trigger

Type of change

  • New feature (non-breaking change which adds functionality)

Docs

  • Docs updated? What were the changes:

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-actions[bot]
github-actions bot reviewed Oct 15, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.

@abhishek7kalra abhishek7kalra mentioned this pull request Oct 15, 2023
Closed
@SkalskiP SkalskiP self-requested a review October 18, 2023 11:47
@SkalskiP SkalskiP added api: linezone LineZone API enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti hacktoberfest-accepted Contribute to the notion of open-source this October! labels Oct 18, 2023
@SkalskiP SkalskiP linked an issue Oct 18, 2023 that may be closed by this pull request
Make sv.LineZone.trigger return bool np.ndarray informing which detections have crossed the line this frame #464
Closed
@SkalskiP SkalskiP merged commit 034c2bd into roboflow:develop Oct 18, 2023
7 checks passed
@SkalskiP
Copy link
Collaborator

Here is a small test confirming everything works as expected.

482-test.mp4

@abhishek7kalra abhishek7kalra deleted the linezonetrigger branch October 21, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@SkalskiP SkalskiP SkalskiP approved these changes

Assignees

@abhishek7kalra abhishek7kalra

Labels
api: linezone LineZone API enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti hacktoberfest-accepted Contribute to the notion of open-source this October!
Projects
Supervision Board
Status: Current Release: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sv.LineZone.trigger return bool np.ndarray informing which detections have crossed the line this frame
3 participants
@abhishek7kalra @CLAassistant @SkalskiP