-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New function [CSVSink] - allowing to serialise Detections to a CSV file #818
New function [CSVSink] - allowing to serialise Detections to a CSV file #818
Conversation
Hi @AdonaiVera 👋🏻 ! Good start. I left a few comments. Let me know if you have any questions. I didn't look at unit tests yet. Let's work on logic first. |
360fd62
to
1256833
Compare
Hi @SkalskiP Thank you for your valuable feedback. I have already implemented the changes and created a PR. Additionally, I updated the demo and moved the unit test to the test/detections folder. Please let me know your thoughts on the changes and if you have any further suggestions 🥷 |
Hi @SkalskiP 👋 I tried to handle multiple scenarios, but I can work with more if needed. But before that, I need to solve the question about what happens if the custom data changes between detections. Thanks 🚀 |
… improvements pattern directory
I made a few docs updates in the meantime. Nothing important. There was no point in forcing you to make corrections. These were very minor things. |
…v' into allowing_serialise_detections_csv
Hi @AdonaiVera 👋🏻 I made two small commits to your branch today. I really wanted to close it out before the weekend. Feel free to ask questions here in comments. Overal awesome work! Thanks a lot for your help! 🔥 |
Thank you! We did an amazing collaborative work. @SkalskiP 💪 Now that I have the full perspective, I'm ready to create the JSON saving function, I'll update that PR soon 🚀 |
Awesome @AdonaiVera! Cant wait to see that! 🔥 |
Description
This PR introduces the
CSVSink
class to address structured logging of object detection data into CSV format, as requested in issue #746. The class supports logging of bounding boxes, class IDs, confidence scores, and frame numbers, enhancing post-processing data analysis and interpretability.The PR includes:
CSVSink
class implementation.CSVSink
with a video processing pipeline.Note: The
CSVSink
class was placed directly in the utils folder in the file.py file due to its capability to handle various types of file operations integral to the project's core functionality. Open to suggestions if there's a more appropriate location within the project structure.Type of Change
CSVSink
class for structured logging of detection data.Testing
The
CSVSink
class was validated through a series of unit tests, covering:A demo script demonstrates the class's usage within a video processing workflow, annotating video frames and logging detections to a CSV file. Demo Here
Documentation Updates
CSVSink
class documentation within the module, detailing its purpose, usage, and example usage.CSVSink
class.