This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
infer.sh: Fix error detection on detect.roboflow.com API endpoint #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detect.roboflow.com API endpoint appears to return one of:
Invalid API key
{"message":"Forbidden"}
Invalid model ID
{"detail":"Not Found"}
Other invalid parameters (e.g. no POST data given)
{"detail":"Method Not Allowed"}
Perhaps in the past, it returned "not authorized" and "does not exist", but not anymore.
Without this patch, running infer.sh carries along merrily until it attempts to put together an output video, and shows a bunch of errors like this one, due to the input files just containing one of the JSON errors listed above:
It might be worth setting up some e2e tests that directly hit the API endpoint (or an internal test instance) to prevent this from happening again.