Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bzlmod example to CI #69

Merged
merged 9 commits into from
Aug 14, 2023
Merged

Add bzlmod example to CI #69

merged 9 commits into from
Aug 14, 2023

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented Aug 10, 2023

Adding Bzlmod support now that Android projects officially support it.

@Bencodes Bencodes requested a review from utzcoz August 11, 2023 08:35
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@utzcoz
Copy link
Member

utzcoz commented Aug 11, 2023

Maybe @brettchabot can help to review as I think he is more professional at bazel.

Copy link
Contributor

@brettchabot brettchabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at bzlmod yet, so I'm not confident my review is adding a ton of value but LGTM

.bcr/presubmit.yml Outdated Show resolved Hide resolved
@utzcoz
Copy link
Member

utzcoz commented Aug 12, 2023

@Bencodes Please merge it by yourself if you think it is ready.

@Bencodes Bencodes merged commit 2c2729e into master Aug 14, 2023
3 checks passed
@Bencodes Bencodes deleted the add-bzlmod-example-to-ci branch August 14, 2023 17:07
@utzcoz
Copy link
Member

utzcoz commented Aug 15, 2023

@Bencodes What about making a new PR to update README.md for bzlmod usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants