Support PackageManager.getXml().

We support this by removing the delegating ShadowApplicationPackageManager.getXml(). This method delegates to DefaultPackageManager which doesn't implement the method leaving StubPackageManager to return null.
robolectric · Mar 9, 2017 · fc444e1 · fc444e1
1 parent 57ad6b6
commit fc444e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...s/shadows-core/src/main/java/org/robolectric/shadows/ShadowApplicationPackageManager.java b/...s/shadows-core/src/main/java/org/robolectric/shadows/ShadowApplicationPackageManager.java
@@ -649,11 +649,6 @@ public CharSequence getText(String packageName, @StringRes int resid, Applicatio
     return getDelegatePackageManager().getText(packageName, resid, appInfo);
   }
 
-  @Implementation
-  public XmlResourceParser getXml(String packageName, @XmlRes int resid, ApplicationInfo appInfo) {
-    return getDelegatePackageManager().getXml(packageName, resid, appInfo);
-  }
-
   @Implementation
   public void installPackage(Uri packageURI, IPackageInstallObserver observer, int flags, String installerPackageName) {
     getDelegatePackageManager().installPackage(packageURI, observer, flags, installerPackageName);

diff --git a/robolectric/src/test/java/org/robolectric/shadows/ShadowPackageManagerTest.java b/robolectric/src/test/java/org/robolectric/shadows/ShadowPackageManagerTest.java
@@ -7,6 +7,7 @@
 import android.content.IntentFilter;
 import android.content.pm.*;
 import android.content.pm.PackageManager;
+import android.content.res.XmlResourceParser;
 import android.graphics.Color;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
@@ -1069,4 +1070,12 @@ public void installerPackageName() throws Exception {
 
     assertThat(packageManager.getInstallerPackageName("target.package")).isEqualTo("installer.package");
   }
+
+  @Test
+  public void getXml() throws Exception {
+    XmlResourceParser in = packageManager.getXml(RuntimeEnvironment.application.getPackageName(),
+        R.xml.dialog_preferences,
+        RuntimeEnvironment.application.getApplicationInfo());
+    assertThat(in).isNotNull();
+  }
 }