Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShadowSmsManager is missing a resetter for static state #3811

Closed
sooniln opened this issue Mar 9, 2018 · 0 comments
Closed

ShadowSmsManager is missing a resetter for static state #3811

sooniln opened this issue Mar 9, 2018 · 0 comments
Assignees
@jongerrish
Milestone
4.0.2

Comments

@sooniln
Copy link
Contributor

sooniln commented Mar 9, 2018

As title, ShadowSmsManager does not reset static state between tests, breaking the class in some scenarios.
@jongerrish jongerrish self-assigned this Nov 1, 2018
@jongerrish jongerrish added this to the 4.0.2 milestone Nov 1, 2018
jongerrish pushed a commit that referenced this issue Nov 1, 2018
Reset static state in SmsManager to avoid test pollution
77bb228 
Removed some unnecessary shadowing code.
Fixes: #3811

PiperOrigin-RevId: 219701388
xian pushed a commit that referenced this issue Nov 9, 2018
@xian
Reset static state in SmsManager to avoid test pollution
4096266 
Removed some unnecessary shadowing code.
Fixes: #3811

PiperOrigin-RevId: 219701388
@xian xian mentioned this issue Nov 9, 2018
Merged
xian pushed a commit that referenced this issue Nov 10, 2018
@xian
Reset static state in SmsManager to avoid test pollution
63f3bf3 
Removed some unnecessary shadowing code.
Fixes: #3811

PiperOrigin-RevId: 219701388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongerrish jongerrish

Labels
None yet
Projects
None yet
Milestone
4.0.2
Development

No branches or pull requests
2 participants
@sooniln @jongerrish