Adding support for scale-independent pixels in Resources.getDimension() #1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale-independent pixels are calculated using
metrics.scaledDensity
.scaledDensity
is set inResources.updateConfiguration()
like this:fontScale
was always 0, meaning thatscaledDensity
also became 0, andresources.getDimension(R.dimen.sp_value)
therefore returned 0 no matter the value.Fixing by running the real
Configuration.setToDefaults()
from the shadow, which then setsfontScale
to 1.