Support for API 22#2030
Merged
Merged
Conversation
added 6 commits
September 9, 2015 15:59
Added missing methods to RoboWebSettings.java
# Conflicts: # robolectric-shadows/shadows-core/src/main/resources/android/app/RobolectricActivityManager.java.vm # robolectric-shadows/shadows-core/src/main/resources/org/robolectric/shadows/ShadowLocaleData.java.vm
… s copy the implementation from API 21 as a shadow implementation. CookieManager is now an abstract class rather than a class of empty implementations. Create RobolectricCookieManager to provide these impleemntations and move the shadow implementations there. Removed test in ShadowCookieManagerSyncTest and non-implementation methods from ShadowCookieManager as it is only used from ShadowCookieSyncManagerTest whose class under test is deprecated and just calls through anyway.
added 3 commits
September 10, 2015 17:57
…agerService() which always returned null service on previous SDKs but since 22 now will make recursive calls till it gets a non-null.
…dicating explicitly empty rather than undefined. The best documentation of this can be seen in the following commit:- https://android.googlesource.com/platform/frameworks/base/+/f296940%5E!/
Closed
kriegfrj
pushed a commit
to kriegfrj/robolectric
that referenced
this pull request
Sep 15, 2015
|
What version of Robolectric is this in? |
Contributor
|
3.1-SNAPSHOT |
ismail-s
added a commit
to ismail-s/KISS
that referenced
this pull request
Nov 20, 2015
See robolectric/robolectric#2030 for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing methods to RoboWebSettings.
Make RobolectricActivityManager implement all API 22 methods.
Added conditional for ShadowLocaleData percent is now a String