Make ShadowPackageManager not abstract. #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows teams to subclass PackageManager without requiring to have a corresponding shadow. The methods it needs to implement come from the RobolectricPackageManager interface which will be removed in 3.4 These are all methods that are available on the framework PackageManager which should be used in preference to the shadow anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows teams to subclass PackageManager without requiring to have a
corresponding shadow.
The methods it needs to implement come from the RobolectricPackageManager
interface which will be removed in 3.4 These are all methods that are
available on the framework PackageManager which should be used in
preference to the shadow anyway.
Fixes #2951