Add ShadowMagnificationController for N+ #6140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_350651958
branch
from
8aa69dc
to
51afa8b
Compare
A single instance of MagnificationController exists per AccessibilityService. It abstracts over sending commands to the framework over Binder. These commands allow the client to magnify areas of the screen, and to query if the screen is currently being magnified. Before this shadow existed, using MagnificationController from Robolectric would have no visible effects. i.e., if you were to call .setScale(n, animate) to modify the magnification scale, then calling .getScale() would not return n: it would instead return the default scale (1f). This shadow keeps internal magnification state, so that the APIs behave as expected. Currently an assumption baked into this code is that only one AccessibilityService is active at once. This should be a safe assumption in general, as there are various disadvantages to having multiple services in an apk (from both the performance perspective, but also from user convenience, as each service has to be activated separately, from a deeply buried Settings page). PiperOrigin-RevId: 350651958
copybara-service
bot
force-pushed
the
piper_350651958
branch
from
51afa8b
to
10fa97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ShadowMagnificationController for N+