Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up test code under shadows #6223

Merged
merged 1 commit into from Feb 20, 2021
Merged

Clean up test code under shadows #6223

merged 1 commit into from Feb 20, 2021

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Feb 17, 2021

  1. Remove redundant throws from test methods.
  2. Use lambda for listener/callback.
  3. Remove redundant cast.
  4. Prefer Collection api than Array.
  5. Fix wrong link in doc.

@utzcoz
Clean up test code under shadows
b090301 
1. Remove redundant throws from test methods.
2. Use lambda for listener/callback.
3. Remove redundant cast.
4. Prefer Collection api than Array.
5. Fix wrong link in doc.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz marked this pull request as ready for review February 17, 2021 15:55
@utzcoz
Copy link
Member Author

utzcoz commented Feb 17, 2021

@hoisie could you help to review this PR? Thanks.

@hoisie
Copy link
Contributor

hoisie commented Feb 19, 2021

Awesome, thanks for doing this. Reviewing it now.

@hoisie hoisie merged commit 4ef2f49 into robolectric:master Feb 20, 2021
@utzcoz utzcoz deleted the clean-up-test-coder-under-shadows branch February 21, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@utzcoz @hoisie