Converting recycleUnchecked calls to use @Direct with reflector(...) in place of ReflectionHelpers. #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_383661920
branch
6 times, most recently
from
a8ebbb1
to
f6ae98a
Compare
…eflector(...). Some recycleUnchecked(...) invocations were eliminated in the earlier conversion of ShadowPausedMessage which was handled automatically by a script. This change is a followup to get an even larger performance gain. Test that posts a Runnable to a Handler 1M times using @LooperMode(LEGACY): Before: Stats over 100 runs: max = 49.9s, min = 20.7s, avg = 30.6s, dev = 5.8s After: Stats over 100 runs: max = 31.4s, min = 15.0s, avg = 22.1s, dev = 3.4s Approximately a 28% performance improvement on average. PiperOrigin-RevId: 383661920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting recycleUnchecked calls to use @direct with reflector(...) in place of ReflectionHelpers.
These calls account for the single most ReflectionHelpers invocations with over 32 billion per day. Some of these invocations were eliminated in the earlier conversion of ShadowPausedMessage which was handled automatically by a script. With this change, there should be no remaining ReflectionHelpers invocations.