Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle-versions-plugin to 0.42.0 #6970

Merged
merged 1 commit into from Mar 22, 2022

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Jan 9, 2022

It's very strange that ./gradlew dependencyUpdates -Drevision=release --info always failed at my laptop with keystore problem:

Caused by: java.security.NoSuchAlgorithmException: Error constructing implementation (algorithm: Default, provider: SunJSSE, class: sun.security.ssl.SSLContextImpl$DefaultSSLContext)
        at java.base/java.security.Provider$Service.newInstance(Provider.java:1900)
        at java.base/sun.security.jca.GetInstance.getInstance(GetInstance.java:236)
        at java.base/sun.security.jca.GetInstance.getInstance(GetInstance.java:164)
        at java.base/javax.net.ssl.SSLContext.getInstance(SSLContext.java:184)
        at java.base/javax.net.ssl.SSLContext.getDefault(SSLContext.java:110)
        at org.gradle.internal.resource.transport.http.HttpClientConfigurer.jdkSupportsTLSProtocol(HttpClientConfigurer.java:114)
        ... 233 more
Caused by: java.security.KeyManagementException: problem accessing trust store
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:78)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)

Hi @hoisie, could you help to verify it at your development machine when you have time? Thanks.

@utzcoz utzcoz requested a review from hoisie January 9, 2022 17:49
@utzcoz
Copy link
Member Author

utzcoz commented Jan 21, 2022

Oh, it's my network problem. I rerun it locally, and it works fine, and show updating list for dependencies. @hoisie could you help to take a look at this PR? Thanks.

@utzcoz
Copy link
Member Author

utzcoz commented Jan 25, 2022

On GitHub, maybe Dependabot(https://github.com/features/security) is more useful for dependencies bumping. We have bumped dependencies many times, but manually. Maybe Dependabot can help us to git rid of this "boring" but useful work.

@utzcoz
Copy link
Member Author

utzcoz commented Jan 27, 2022

On GitHub, maybe Dependabot(https://github.com/features/security) is more useful for dependencies bumping. We have bumped dependencies many times, but manually. Maybe Dependabot can help us to git rid of this "boring" but useful work.

Hi @hoisie , could you help to take look at it? Thanks.

@utzcoz utzcoz force-pushed the bump-gradle-versions-plugin branch from 57702de to 691e849 Compare February 7, 2022 16:55
@utzcoz utzcoz changed the title Bump gradle-versions-plugin to 0.41.0 Bump gradle-versions-plugin to 0.42.0 Feb 7, 2022
@utzcoz
Copy link
Member Author

utzcoz commented Feb 7, 2022

Emm, looks like 0.42.0 has a problem when processing Robolectric's configuration:

The exception that is the cause of unresolved state: org.gradle.internal.resolve.ModuleVersionResolveException: Could not resolve org.robolectric:robolectric:+.
Required by:
    project :robolectric
Caused by: org.gradle.internal.component.model.ConfigurationNotFoundException: Project :robolectric declares a dependency from configuration 'checkApiChangesFromCopy2' to configuration 'default' which is not declared in the descriptor for project :robolectric.
        at org.gradle.internal.component.model.LocalComponentDependencyMetadata.selectConfigurations(LocalComponentDependencyMetadata.java:150)
        at org.gradle.internal.component.local.model.DslOriginDependencyMetadataWrapper.selectConfigurations(DslOriginDependencyMetadataWrapper.java:71)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.graph.builder.EdgeState.calculateTargetConfigurations(EdgeState.java:265)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.graph.builder.EdgeState.attachToTargetConfigurations(EdgeState.java:150)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.graph.builder.DependencyGraphBuilder.attachToTargetRevisionsSerially(DependencyGraphBuilder.java:376)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.graph.builder.DependencyGraphBuilder.resolveEdges(DependencyGraphBuilder.java:261)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.graph.builder.DependencyGraphBuilder.traverseGraph(DependencyGraphBuilder.java:198)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.graph.builder.DependencyGraphBuilder.resolve(DependencyGraphBuilder.java:149)
        at org.gradle.api.internal.artifacts.ivyservice.resolveengine.DefaultArtifactDependencyResolver.resolve(DefaultArtifactDependencyResolver.java:145)
        at org.gradle.api.internal.artifacts.ivyservice.DefaultConfigurationResolver.resolveGraph(DefaultConfigurationResolver.java:186)
        at org.gradle.api.internal.artifacts.ivyservice.ShortCircuitEmptyConfigurationResolver.resolveGraph(ShortCircuitEmptyConfigurationResolver.java:85)
        at org.gradle.api.internal.artifacts.ivyservice.ErrorHandlingConfigurationResolver.resolveGraph(ErrorHandlingConfigurationResolver.java:74)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$1.call(DefaultConfiguration.java:644)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$1.call(DefaultConfiguration.java:635)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.resolveGraphIfRequired(DefaultConfiguration.java:635)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.lambda$resolveExclusively$4(DefaultConfiguration.java:615)
        at org.gradle.api.internal.project.DefaultProjectStateRegistry$CalculatedModelValueImpl.update(DefaultProjectStateRegistry.java:478)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.resolveExclusively(DefaultConfiguration.java:612)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.resolveToStateOrLater(DefaultConfiguration.java:599)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.getResolvedConfiguration(DefaultConfiguration.java:574)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration_Decorated.getResolvedConfiguration(Unknown Source)
        at com.github.benmanes.gradle.versions.updates.Resolver.resolve(Resolver.groovy:80)

@utzcoz utzcoz marked this pull request as draft March 7, 2022 10:47
Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz force-pushed the bump-gradle-versions-plugin branch from 691e849 to 46b7171 Compare March 22, 2022 14:06
@utzcoz
Copy link
Member Author

utzcoz commented Mar 22, 2022

We can run ./gradlew dependencyUpdates -Drevision=release to omit related error info, because it will not affect us.

@utzcoz utzcoz marked this pull request as ready for review March 22, 2022 14:49
@utzcoz
Copy link
Member Author

utzcoz commented Mar 22, 2022

@hoisie I think it can be reviewed now.

@utzcoz utzcoz merged commit 3abae77 into robolectric:master Mar 22, 2022
@utzcoz utzcoz deleted the bump-gradle-versions-plugin branch March 22, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants