New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kotlin to 1.7.10 #7497
Bump Kotlin to 1.7.10 #7497
Conversation
858824d
to
f25ea1b
Compare
@brettchabot Looks like current Kotlin configuration can't use Kotlin 7.10 directly. I will investigate it at weekend to see why. |
@brettchabot I didn't find the root cause of building error after bumping Kotlin to 1.7.10, but I found that the utils module's Kotlin plugin dependency has affected its usage by other modules, like shadowapi module when bumping Kotlin to latest version. I think I can understand a little of what @kingargyle said about Kotlin's compatibility. cc @hellosagar @hoisie . |
The stacktrace is here:
|
f25ea1b
to
47bc1b8
Compare
47bc1b8
to
de7c864
Compare
7b6d3df
to
9017ec2
Compare
@brettchabot From your work to using latest AndroidX test libraries at #7683, I think we also need to add |
Signed-off-by: utzcoz <utzcoz@outlook.com>
9017ec2
to
37b2e5d
Compare
37b2e5d
to
25a17a5
Compare
Update with command `./gradlew wrapper --gradle-version 7.5.1`. Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
fb5294d
to
e6845ec
Compare
1. Add artifactType with jar for utils' runtimeElements We should add artifactType with jar to ensure standard runtimeElements variant has a max priority selection sequence than other variants that brought by kotlin plugin. 2. Use annotations module to replace shadowapi for androidx_test androidx_test only needs annotations module, instead of a larger one called shadowapi. 3. Use java/main to replace kotlin/main for utils modules Use java/main classes directory to replace default kotlin/main to avoid d8 error when dexing & desugaring kotlin classes with non-exist kotlin/main directory because utils module doesn't have kotlin code in production. If utils module starts to add Kotlin code in main source set, we can remove this destinationDirectory modification. Signed-off-by: utzcoz <utzcoz@outlook.com>
e6845ec
to
a145b0d
Compare
@brettchabot @hoisie I think we can bump Kotlin to 1.7.10 now after some weekend's work. There are some changes that need to highlight:
|
Friendly ping @hoisie @brettchabot for review. |
The AGP 7.3.0 only supports kotlin-android 1.5.20 and higher version.