Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ShadowAccountManager #7636

Merged
merged 2 commits into from Sep 24, 2022
Merged

Clean up ShadowAccountManager #7636

merged 2 commits into from Sep 24, 2022

Commits on Sep 24, 2022

  1. Remove unused deprecated from protected ShadowAccountManager#get 

    This deprecated annotation is added when converting public
implementation method to protected. And all convertions were finished,
and we can remove deprecated annotation now.

Signed-off-by: utzcoz <utzcoz@outlook.com>
    @utzcoz
    utzcoz committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    105ba98 View commit details
    Browse the repository at this point in the history

  2. Remove unused Exceptions from ShadowAccountManager methods 

    These methods are used in internal of ShadowAccountManager, so it's safe
to remove exceptions from method's signature.

Signed-off-by: utzcoz <utzcoz@outlook.com>
    @utzcoz
    utzcoz committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    7bee6d0 View commit details
    Browse the repository at this point in the history