Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate instance calling in ReflectionHelpers to lambda #7644

Merged
merged 1 commit into from Sep 25, 2022
Merged

Migrate instance calling in ReflectionHelpers to lambda #7644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
101 changes: 44 additions & 57 deletions shadowapi/src/main/java/org/robolectric/util/ReflectionHelpers.java
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@
import java.lang.annotation.Annotation;
import java.lang.reflect.Constructor;
import java.lang.reflect.Field;
import java.lang.reflect.InvocationHandler;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
Expand Down Expand Up @@ -56,16 +55,13 @@ public static <T> T createDeepProxy(Class<T> clazz) {
Proxy.newProxyInstance(
clazz.getClassLoader(),
new Class[] {clazz},
new InvocationHandler() {
@Override
public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
if (PRIMITIVE_RETURN_VALUES.containsKey(method.getReturnType().getName())) {
return PRIMITIVE_RETURN_VALUES.get(method.getReturnType().getName());
} else if (method.getReturnType().isInterface()) {
return createDeepProxy(method.getReturnType());
} else {
return null;
}
(proxy, method, args) -> {
if (PRIMITIVE_RETURN_VALUES.containsKey(method.getReturnType().getName())) {
return PRIMITIVE_RETURN_VALUES.get(method.getReturnType().getName());
} else if (method.getReturnType().isInterface()) {
return createDeepProxy(method.getReturnType());
} else {
return null;
}
});
}
Expand All @@ -76,32 +72,27 @@ public static <T> T createDelegatingProxy(Class<T> clazz, final Object delegate)
Proxy.newProxyInstance(
clazz.getClassLoader(),
new Class[] {clazz},
new InvocationHandler() {
@Override
public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
try {
Method delegateMethod =
delegateClass.getMethod(method.getName(), method.getParameterTypes());
delegateMethod.setAccessible(true);
return delegateMethod.invoke(delegate, args);
} catch (NoSuchMethodException e) {
return PRIMITIVE_RETURN_VALUES.get(method.getReturnType().getName());
} catch (InvocationTargetException e) {
// Required to propagate the correct throwable.
throw e.getTargetException();
}
(proxy, method, args) -> {
try {
Method delegateMethod =
delegateClass.getMethod(method.getName(), method.getParameterTypes());
delegateMethod.setAccessible(true);
return delegateMethod.invoke(delegate, args);
} catch (NoSuchMethodException e) {
return PRIMITIVE_RETURN_VALUES.get(method.getReturnType().getName());
} catch (InvocationTargetException e) {
// Required to propagate the correct throwable.
throw e.getTargetException();
}
});
}

public static <A extends Annotation> A defaultsFor(Class<A> annotation) {
return annotation.cast(
Proxy.newProxyInstance(annotation.getClassLoader(), new Class[] { annotation },
new InvocationHandler() {
@Override public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
return method.getDefaultValue();
}
}));
Proxy.newProxyInstance(
annotation.getClassLoader(),
new Class[] {annotation},
(proxy, method, args) -> method.getDefaultValue()));
}

/**
Expand All @@ -118,13 +109,10 @@ public static <R> R getField(final Object object, final String fieldName) {
return traverseClassHierarchy(
object.getClass(),
NoSuchFieldException.class,
new InsideTraversal<R>() {
@Override
public R run(Class<?> traversalClass) throws Exception {
Field field = getDeclaredField(traversalClass, fieldName);
field.setAccessible(true);
return (R) field.get(object);
}
traversalClass -> {
Field field = getDeclaredField(traversalClass, fieldName);
field.setAccessible(true);
return (R) field.get(object);
});
} catch (Exception e) {
throw new RuntimeException(e);
Expand All @@ -143,15 +131,13 @@ public static void setField(final Object object, final String fieldName, final O
traverseClassHierarchy(
object.getClass(),
NoSuchFieldException.class,
new InsideTraversal<Void>() {
@Override
public Void run(Class<?> traversalClass) throws Exception {
Field field = getDeclaredField(traversalClass, fieldName);
field.setAccessible(true);
field.set(object, fieldNewValue);
return null;
}
});
(InsideTraversal<Void>)
traversalClass -> {
Field field = getDeclaredField(traversalClass, fieldName);
field.setAccessible(true);
field.set(object, fieldNewValue);
return null;
});
} catch (Exception e) {
throw new RuntimeException(e);
}
Expand Down Expand Up @@ -257,15 +243,14 @@ public static <R> R callInstanceMethod(
final Class<?>[] classes = ClassParameter.getClasses(classParameters);
final Object[] values = ClassParameter.getValues(classParameters);

return traverseClassHierarchy(instance.getClass(), NoSuchMethodException.class, new InsideTraversal<R>() {
@Override
@SuppressWarnings("unchecked")
public R run(Class<?> traversalClass) throws Exception {
Method declaredMethod = traversalClass.getDeclaredMethod(methodName, classes);
declaredMethod.setAccessible(true);
return (R) declaredMethod.invoke(instance, values);
}
});
return traverseClassHierarchy(
instance.getClass(),
NoSuchMethodException.class,
traversalClass -> {
Method declaredMethod = traversalClass.getDeclaredMethod(methodName, classes);
declaredMethod.setAccessible(true);
return (R) declaredMethod.invoke(instance, values);
});
} catch (InvocationTargetException e) {
if (e.getTargetException() instanceof RuntimeException) {
throw (RuntimeException) e.getTargetException();
Expand Down Expand Up @@ -442,7 +427,9 @@ public static <R> R callConstructor(
}
}

private static <R, E extends Exception> R traverseClassHierarchy(Class<?> targetClass, Class<? extends E> exceptionClass, InsideTraversal<R> insideTraversal) throws Exception {
private static <R, E extends Exception> R traverseClassHierarchy(
Class<?> targetClass, Class<? extends E> exceptionClass, InsideTraversal<R> insideTraversal)
throws Exception {
Class<?> hierarchyTraversalClass = targetClass;
while (true) {
try {
Expand Down